Skip to content

Adds a Video Courses link to the Learn drop down #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Adds a Video Courses link to the Learn drop down #2099

merged 4 commits into from
Apr 25, 2019

Conversation

Gregg
Copy link
Contributor

@Gregg Gregg commented Apr 4, 2019

Adding "Video Courses" link under Learn in the nav bar. This links to the Vue Mastery courses page.

skitched-20190404-114055

@hootlex
Copy link
Member

hootlex commented Apr 5, 2019

I don’t think Video Courses is a proper title for the link, how about Vue Mastery?
Naming the link courses makes the content look official for many people and grants authority to vm over other learning platforms like Vue School. This is unfair and can be misleading since there are many great courses out there. What do you think @yyx990803 @Gregg ?

@Gregg
Copy link
Contributor Author

Gregg commented Apr 8, 2019

Sorry for the delayed response, I've been out of town.

Thanks for speaking up @hootlex, the last thing I want to do is anything that discourages teachers from creating Vue courses. That being said, it's probably important that we know how and why Vue Mastery is getting this link. Is it a "Sponsored" link? If so, does a sponsor (with Evan's approval) get to suggest what text goes here? @yyx990803 what do you think?

I'm not sure about verbiage. Adam and I spoke a great deal about what should go here. I don't think simply putting "Vue Mastery" communicates what is behind the link. We could write "Vue Mastery Courses" but that's a lot of text compared to the other links on this Nav. "Video Courses" was the shortest and most understandable we came up with. I'd like to hear @yyx990803 's thoughts.

@yyx990803
Copy link
Member

My suggestion: how about a sub section (like the ones in the Ecosystem dropdown) titled "Video Courses", then with VueMastery link and potentially other course links?

@Gregg
Copy link
Contributor Author

Gregg commented Apr 15, 2019

I added a subsection (see screenshot below). I do think it will need to be clear how learning resources get a link added onto this subsection, as I'm sure others will ask. Since they will make money from this link, I think Vue.js should get some sort of sponsorship $ up front.

subsection

@hootlex
Copy link
Member

hootlex commented Apr 16, 2019

@yyx990803 sounds good 👍

@sdras sdras merged commit 6790f51 into vuejs:master Apr 25, 2019
@vue-bot
Copy link
Contributor

vue-bot commented Apr 25, 2019

Hey @Gregg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@sdras
Copy link
Member

sdras commented Apr 25, 2019

Looks good now, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants