-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Adds a Video Courses link to the Learn drop down #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don’t think |
Sorry for the delayed response, I've been out of town. Thanks for speaking up @hootlex, the last thing I want to do is anything that discourages teachers from creating Vue courses. That being said, it's probably important that we know how and why Vue Mastery is getting this link. Is it a "Sponsored" link? If so, does a sponsor (with Evan's approval) get to suggest what text goes here? @yyx990803 what do you think? I'm not sure about verbiage. Adam and I spoke a great deal about what should go here. I don't think simply putting "Vue Mastery" communicates what is behind the link. We could write "Vue Mastery Courses" but that's a lot of text compared to the other links on this Nav. "Video Courses" was the shortest and most understandable we came up with. I'd like to hear @yyx990803 's thoughts. |
My suggestion: how about a sub section (like the ones in the Ecosystem dropdown) titled "Video Courses", then with VueMastery link and potentially other course links? |
@yyx990803 sounds good 👍 |
Hey @Gregg, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Looks good now, thanks everyone! |
Adding "Video Courses" link under Learn in the nav bar. This links to the Vue Mastery courses page.