Skip to content

Add alt text to images to help with screen reader accessibility #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions themes/vue/_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,61 +15,88 @@ special_sponsors:
platinum_sponsors:
- url: http://tooltwist.com/
img: tooltwist.png
name: tool twist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be "tooltwist"

- url: https://vueschool.io/?utm_source=Vuejs.org&utm_medium=Banner&utm_campaign=Sponsored%20Banner&utm_content=V1
img: vueschool.png
name: vue school
- url: https://vehikl.com/
img: vehikl.png
name: vehikl

gold_sponsors:
- url: https://laravel.com
img: laravel.png
name: laravel
- url: https://htmlburger.com
img: htmlburger.png
name: html burger
- url: https://chaitin.cn/en/
img: chaitin.png
name: chaitin
- url: https://anymod.com
img: anymod.png
name: anymod
- url: https://www.frontenddeveloperlove.com/
img: frontend-love.png
name: frontend love
- url: https://onsen.io/vue/
img: onsen-ui.png
name: onsen ui
- url: https://vuetifyjs.com
img: vuetify.png
name: vuetify
- url: https://neds.com.au/
img: neds.png
name: neds
- url: https://hackr.io/tutorials/learn-vue-js
img: hackr-io.png
name: hacker io
- url: https://icons8.com/
img: icons8.png
name: icons 8
- url: https://vuejobs.com/?ref=vuejs
img: vuejobs.png
name: vue jobs
- url: https://leanpub.com/vuejs2
img: tmvuejs2.png
name: the mastery of vue js 2
- url: https://codepilot.ai
img: codepilot.png
name: code pilot
- url: https://teamextension.io/
img: teamextension.png
name: team extension
- url: https://jsguru.io/
img: jsguru.png
name: js guru
- url: http://aaha.co/
img: aaha.png
name: aaha
- url: https://www.valuecoders.com
img: valuecoders.png
name: value coders dot org
- url: https://www.nsoft.com/careers/
img: nsoft.png
name: n soft
- url: https://www.pubnub.com/vue-js/
img: pubnub.png
name: pub nub

silver_sponsors:
- url: https://dopamine.bg/
img: dopamine.png
name: dopamine

bronze_sponsors:
- url: http://tighten.co/
img: http://i.imgur.com/T7fQYLT.png
name: tighten
- url: https://alligator.io
img: https://alligator.io/images/alligator-logo.svg
name: alligator dot io
- url: https://www.accelebrate.com/
img: https://www.accelebrate.com/assets/images/[email protected]
name: accelebrate
- url: https://pullstring.com
img: https://i.imgur.com/hQHW6TB.png
name: pull string
6 changes: 3 additions & 3 deletions themes/vue/layout/index.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div id="hero">
<div class="inner">
<div class="left">
<img class="hero-logo" src="<%- url_for("/images/logo.png") %>">
<img class="hero-logo" src="<%- url_for("/images/logo.png") %>" alt="vue logo">
</div><div class="right">
<h2 class="vue">Vue.js</h2>
<h1>
Expand All @@ -32,12 +32,12 @@
<h3>Special Sponsors</h3>
<br>
<a href="https://stdlib.com/" target="_blank">
<img src="/images/stdlib.png" style="width:140px">
<img src="/images/stdlib.png" style="width:140px" alt="Standard Library Logo">
<span>Function as a Service Platform and Library</span>
</a>
<br>
<a href="https://www.bitsrc.io/?utm_source=vue&utm_medium=vue&utm_campaign=vue&utm_term=vue&utm_content=vue" target="_blank">
<img src="/images/bit.png" style="width:60px;height:60px">
<img src="/images/bit.png" style="width:60px;height:60px" alt="bit logo">
<span>The fastest way to share code</span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion themes/vue/layout/partials/header.ejs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div id="header">
<a id="logo" href="<%- url_for("/") %>">
<img src="<%- url_for("/images/logo.png") %>">
<img src="<%- url_for("/images/logo.png") %>" alt="vue logo">
<span>Vue.js</span>
</a>
<ul id="nav">
Expand Down
8 changes: 4 additions & 4 deletions themes/vue/layout/partials/sponsors.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

<%_ for (const sponsor of theme.platinum_sponsors) {_%>
<a href="<%- sponsor.url %>" target="_blank" style="width: 160px;">
<img src="<%- url_for(`/images/${sponsor.img}`) %>" style="width: 160px;">
<img src="<%- url_for(`/images/${sponsor.img}`) %>" style="width: 160px;" alt="<%-sponsor.name-%>">
</a>
<%_ } _%>
<br>
<br>
<%_ for (const sponsor of theme.gold_sponsors) {_%>
<a href="<%- sponsor.url %>" target="_blank" style="width: 120px;">
<img src="<%- url_for(`/images/${sponsor.img}`) %>" style="width: 120px;">
<img src="<%- url_for(`/images/${sponsor.img}`) %>" style="width: 120px;" alt="<%-sponsor.name-%>">
</a>
<%_ } _%>
<br>
Expand All @@ -19,13 +19,13 @@
<div class="open-collective-sponsors">
<h3>OpenCollective Sponsors</h3>
<h4>Platinum</h4>
<%_ for (let i = 0; i < 3; i++) {_%>
<%_ for (let i = 0; i < 2; i++) {_%>
<a href="https://opencollective.com/vuejs/tiers/platinum-sponsors/<%- i %>/website" target="_blank">
<img src="https://opencollective.com/vuejs/tiers/platinum-sponsors/<%- i %>/avatar.svg">
</a>
<%_ } _%>
<h4>Gold</h4>
<%_ for (let i = 0; i < 10; i++) {_%>
<%_ for (let i = 0; i < 8; i++) {_%>
<a href="https://opencollective.com/vuejs/tiers/gold-sponsors/<%- i %>/website" target="_blank">
<img src="https://opencollective.com/vuejs/tiers/gold-sponsors/<%- i %>/avatar.svg">
</a>
Expand Down
4 changes: 2 additions & 2 deletions themes/vue/layout/partials/sponsors_sidebar.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div>
<%_ for (const sponsor of theme.special_sponsors) {_%>
<a href="<%- sponsor.url %>" target="_blank" class="logo">
<img src="<%- url_for(`/images/${sponsor.wide_img || sponsor.img}`) %>">
<img src="<%- url_for(`/images/${sponsor.wide_img || sponsor.img}`) %>" alt="<%-sponsor.name-%>">
</a>
<%_ } _%>
</div>
Expand All @@ -17,7 +17,7 @@
<div>
<%_ for (const sponsor of theme.platinum_sponsors) {_%>
<a href="<%- sponsor.url %>" target="_blank" class="logo">
<img src="<%- url_for(`/images/${sponsor.wide_img || sponsor.img}`) %>">
<img src="<%- url_for(`/images/${sponsor.wide_img || sponsor.img}`) %>" alt="<%-sponsor.name-%>">
</a>
<%_ } _%>
</div>
Expand Down