This repository was archived by the owner on Jan 18, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 150
[plugin-next] Fix Rollup when no template in an SFC #387
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
85f0e0f
test: make simple test more precise
24bf6ea
test: add the no-template example for test
a35ce0e
fix: when an SFC has no template leave render
6d304f5
test: fix import example
ad1f489
fix: missed template point
ebfced5
tests: add missing dependencies necessary for test
elevatebart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "simple", | ||
"version": "0.0.0", | ||
"private": true, | ||
"scripts": { | ||
"build": "rollup -c" | ||
}, | ||
"dependencies": { | ||
"rollup": "^2.10.9", | ||
"rollup-plugin-vue": "link:../.." | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import VuePlugin from 'rollup-plugin-vue' | ||
|
||
export default [ | ||
{ | ||
input: 'src/HelloWorld.vue', | ||
output: { | ||
file: 'dist/HelloWorld.js', | ||
format: 'esm', | ||
sourcemap: 'inline', | ||
}, | ||
plugins: [VuePlugin()], | ||
external: ['vue'], | ||
}, | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<script> | ||
import h from 'vue' | ||
|
||
export default { | ||
props: ['name'], | ||
render() { | ||
return h('div', 'my render') | ||
}, | ||
} | ||
</script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -417,13 +417,17 @@ function transformVueSFC( | |
const id = hash(isProduction ? shortFilePath + '\n' + code : shortFilePath) | ||
// feature information | ||
const hasScoped = descriptor.styles.some((s) => s.scoped) | ||
const templateImport = getTemplateCode( | ||
descriptor, | ||
resourcePath, | ||
id, | ||
hasScoped, | ||
isServer | ||
) | ||
|
||
const templateImport = descriptor.template | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The right condition is |
||
? '' | ||
: getTemplateCode(descriptor, resourcePath, id, hasScoped, isServer) | ||
|
||
const renderReplace = !descriptor.template | ||
? '' | ||
: isServer | ||
? `script.ssrRender = ssrRender` | ||
: `script.render = render` | ||
|
||
const scriptImport = getScriptCode(descriptor, resourcePath) | ||
const stylesCode = getStyleCode( | ||
descriptor, | ||
|
@@ -441,7 +445,7 @@ function transformVueSFC( | |
templateImport, | ||
stylesCode, | ||
customBlocksCode, | ||
isServer ? `script.ssrRender = ssrRender` : `script.render = render`, | ||
renderReplace, | ||
] | ||
if (hasScoped) { | ||
output.push(`script.__scopeId = ${_(`data-v-${id}`)}`) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h
isnt' the default export, you should useimport { h } from 'vue'