This repository was archived by the owner on Jan 18, 2022. It is now read-only.
fix: Prevent conflicting filename for sourcemaps #375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238. Related to #215 and maybe #248.
Changes proposed in this pull request:
I think Rollup doesn't like that the Vue plugin outputs multiple sourcemaps with the same names because it triggers the following error when running
rollup --watch
:https://github.com/rollup/rollup/blob/0ffbe94981a1201da851eb6001cce7bb5b8efb20/src/utils/collapseSourcemaps.ts#L79-L86
I have a dumb patch to propose, hoping to bring attention to the problem and get help to solve it properly. It's reproducing on v5 and also the new v6. I think since the sourcemaps have been introduced.
I ignore whether renaming the sourcemaps affects other parts of the build. So I choose to leave the sourcemaps for
script
untouched, while renaming the others (which are less critical, at least for my usage).I read in one of the comments that it may be due to
@vue/compiler-sfc
... but I prefer to ask for help first before digging into that too 😅 I can write the tests once we are certain about the solution./ping @znck 🙏