Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Remove ES6 transpiling and add <style> support #10

Closed
wants to merge 6 commits into from
Closed

Remove ES6 transpiling and add <style> support #10

wants to merge 6 commits into from

Conversation

thgh
Copy link

@thgh thgh commented Aug 19, 2016

I hope this PR doesn't diverge too much from what you had in mind for this plugin. The transpiling has been removed completely, which can now be done as a separate plugin (see below).

Some notes:

  • Unwanted Treating '...' as external dependency even when using node-resolve & commonjs.
  • Should use ongenerate instead of banner
  • Might have removed too much Promises.
  • Currently when using multiple style->lang values, each value gets a file. Can be optimized. To be discussed in How to rollup Vue component with styles? #7
  • Should check compatibility with the babel plugin Please remove babel dependency #8

Example rollup.config.js

import vue from 'rollup-plugin-vue'
import buble from 'rollup-plugin-buble'

export default {
  entry: 'src/main.js',
  dest: 'dist/bundle.js',
  plugins: [
    vue(),
    buble()
  ]
}

@znck
Copy link
Member

znck commented Aug 19, 2016

This looks cool.

thgh added 3 commits August 20, 2016 01:03
Update console output to be more like webpack
@znck
Copy link
Member

znck commented Aug 20, 2016

@thgh I guess I have applied your commits. Please sync your fork.

@znck znck closed this Aug 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants