Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

[Bug] Generated bundle is missing the with statement #20

Closed
posva opened this issue Sep 11, 2016 · 9 comments
Closed

[Bug] Generated bundle is missing the with statement #20

posva opened this issue Sep 11, 2016 · 9 comments

Comments

@posva
Copy link
Member

posva commented Sep 11, 2016

When using the compileTemplate option the render function doesn't have the with statement.
Example on #19

@posva posva mentioned this issue Sep 11, 2016
@znck
Copy link
Member

znck commented Sep 11, 2016

Cannot reproduce!

Worked fine for the example on #19 .

@posva
Copy link
Member Author

posva commented Sep 11, 2016

No way 😢
Let me chek better

@znck
Copy link
Member

znck commented Sep 11, 2016

I am using following dependencies!

$ npm ls
[email protected] /Users/znck/Workspace/rollup-plugin-vue
├─┬ [email protected]
├─┬ [email protected]
├── [email protected]
├─┬ [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
├── [email protected]
├─┬ [email protected]
├─┬ [email protected]
├── [email protected]
├── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected]
├─┬ [email protected]
├─┬ [email protected]
├─┬ [email protected]
├─┬ [email protected]
├─┬ [email protected]
├── [email protected]
├─┬ [email protected]

@znck znck added the bug label Sep 11, 2016
@posva
Copy link
Member Author

posva commented Sep 11, 2016

I reinstalled the node modules and it's the same:

screen shot 2016-09-11 at 12 31 58

I also forgot to install rollup as a devdep in #19 btw

@znck
Copy link
Member

znck commented Sep 11, 2016

Just did same from master.

screen shot 2016-09-11 at 18 16 54

And with(this)

screen shot 2016-09-11 at 18 19 20

@znck znck closed this as completed Sep 11, 2016
@posva
Copy link
Member Author

posva commented Sep 11, 2016

I messed up with that screenshot. That was for css (which is working fine right now).
I'm still missing the with statement using master branch:

screen shot 2016-09-11 at 16 31 39

I'll try reinstalling modules again 😕

edit: BTW nice reactivity! I wasn't expecting all of those to be fixed today 😄

@posva
Copy link
Member Author

posva commented Sep 11, 2016

@znck Still happening with a fresh install and node v6.5.0

znck added a commit that referenced this issue Sep 11, 2016
@znck
Copy link
Member

znck commented Sep 11, 2016

Buble removes statically conditions resolved conditions.

if ('__VUE_WITH_STATEMENT__') // is always true

@posva
Copy link
Member Author

posva commented Sep 11, 2016

I tested using window.__VUE_WITH_STATEMENT__ and it works 😄
edit: Oh, you already fixed that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants