Add `no-shared-component-data` rule. #84

armano2 · 2017-07-16T13:59:43Z

This PR implements rules proposed in #79

DONE:

Create documtation
Add tests
Implement rule

Importnant:

This rule splits executeOnVueComponent into executeOnVueInstance and executeOnVueComponent and adds alias executeOnVue

if you want to process only Vue components use utils.executeOnVueComponent
if you want to process only new Vue use utils.executeOnVueInstance
If you want to process both use utils.executeOnVue

armano2 · 2017-07-19T16:20:39Z

@michalsnik cleaned up and merged

mysticatea · 2017-07-19T22:12:36Z

I'm considering the rule name. In general, eslint rules which disallow something starts with no-.

I don't have the best idea, but maybe no-shared-component-data?
I guess that it's shared by component instances if the data is not a function.

armano2 · 2017-07-19T22:23:43Z

@mysticatea no-shared-component-data make more sense than component-data, i will rename it

michalsnik

Few minor suggestions @armano2

michalsnik · 2017-07-21T09:17:47Z

lib/rules/no-shared-component-data.js

+        ).forEach(cp => {
+          context.report({
+            node: cp.value,
+            message: 'Component `data` must be a function.'


What do you think about changing the message to:
data property in component must be a function

michalsnik · 2017-07-21T09:18:27Z

lib/rules/no-shared-component-data.js

+module.exports = {
+  meta: {
+    docs: {
+      description: 'Enforces that a component data must be a function',


component's

michalsnik · 2017-07-21T09:21:48Z

docs/rules/no-shared-component-data.md

@@ -0,0 +1,33 @@
+# Enforces that a component data must be a function (no-shared-component-data)


What about: Enforces component's data property to be a function ?

michalsnik · 2017-07-21T09:22:43Z

lib/rules/no-shared-component-data.js

@@ -0,0 +1,51 @@
+/**
+ * @fileoverview When using the data property on a component (i.e. anywhere except on new Vue), the value must be a function that returns an object.


I'd use the same title as in documentation

michalsnik · 2017-07-21T09:23:27Z

lib/rules/no-shared-component-data.js

+          p.key.name === 'data' &&
+          p.value.type !== 'FunctionExpression' &&
+          p.value.type !== 'Identifier'
+        ).forEach(cp => {


Move .forEach to new line for consistency

armano2 · 2017-07-22T12:30:17Z

@michalsnik suggestions applied + i rebased changes and applied executeOnVueInstance, executeOnVueComponent, executeOnVue to already merged code.

michalsnik · 2017-07-22T12:42:41Z

lib/rules/no-shared-component-data.js

+  // Public
+  // ----------------------------------------------------------------------
+
+  return Object.assign({},


Object.assign seems to be redundant

armano2 · 2017-07-23T13:09:37Z

@michalsnik fixed

armano2 changed the title ~~WIP: Add component-date rule.~~ Add component-date rule. Jul 16, 2017

armano2 changed the title ~~Add component-date rule.~~ Add component-data rule. Jul 16, 2017

michalsnik added do not merge Ready for review labels Jul 16, 2017

armano2 force-pushed the patch-8-component-data branch from 89f7ec3 to 8f4c945 Compare July 19, 2017 16:20

mysticatea added the semver-minor label Jul 19, 2017

armano2 changed the title ~~Add component-data rule.~~ Add no-shared-component-data rule. Jul 19, 2017

michalsnik removed the do not merge label Jul 21, 2017

michalsnik reviewed Jul 21, 2017

View reviewed changes

Add no-shared-component-data rule.

7453a77

armano2 force-pushed the patch-8-component-data branch from 5992614 to 7453a77 Compare July 22, 2017 12:29

michalsnik suggested changes Jul 23, 2017

View reviewed changes

armano2 added 2 commits July 23, 2017 15:07

Merge branch 'master' into patch-8-component-data

689e0ea

Remove redundant code & merge with master

8718deb

michalsnik approved these changes Jul 23, 2017

View reviewed changes

michalsnik merged commit 1ea1396 into vuejs:master Jul 23, 2017

michalsnik removed the Ready for review label Jul 23, 2017

armano2 deleted the patch-8-component-data branch July 23, 2017 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `no-shared-component-data` rule. #84

Add `no-shared-component-data` rule. #84

armano2 commented Jul 16, 2017 •

edited

Loading

armano2 commented Jul 19, 2017

mysticatea commented Jul 19, 2017

armano2 commented Jul 19, 2017

michalsnik left a comment

michalsnik Jul 21, 2017

michalsnik Jul 21, 2017

michalsnik Jul 21, 2017

michalsnik Jul 21, 2017

michalsnik Jul 21, 2017

armano2 commented Jul 22, 2017 •

edited

Loading

michalsnik Jul 22, 2017

armano2 commented Jul 23, 2017

		@@ -0,0 +1,33 @@
		# Enforces that a component data must be a function (no-shared-component-data)

		@@ -0,0 +1,51 @@
		/**
		* @fileoverview When using the data property on a component (i.e. anywhere except on new Vue), the value must be a function that returns an object.

Add no-shared-component-data rule. #84

Add no-shared-component-data rule. #84

Conversation

armano2 commented Jul 16, 2017 • edited Loading

armano2 commented Jul 19, 2017

mysticatea commented Jul 19, 2017

armano2 commented Jul 19, 2017

michalsnik left a comment

Choose a reason for hiding this comment

michalsnik Jul 21, 2017

Choose a reason for hiding this comment

michalsnik Jul 21, 2017

Choose a reason for hiding this comment

michalsnik Jul 21, 2017

Choose a reason for hiding this comment

michalsnik Jul 21, 2017

Choose a reason for hiding this comment

michalsnik Jul 21, 2017

Choose a reason for hiding this comment

armano2 commented Jul 22, 2017 • edited Loading

michalsnik Jul 22, 2017

Choose a reason for hiding this comment

armano2 commented Jul 23, 2017

Add `no-shared-component-data` rule. #84

Add `no-shared-component-data` rule. #84

armano2 commented Jul 16, 2017 •

edited

Loading

armano2 commented Jul 22, 2017 •

edited

Loading