Skip to content

#65 - vue/no-invalid-v-for shouldn't catch slots #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2017

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jul 4, 2017

#65

@armano2
Copy link
Contributor Author

armano2 commented Jul 4, 2017

I think we should add few additional internal vue elements like <router-view> <transition> <transition-group>
but they should be not allowed?

@mysticatea
Copy link
Member

mysticatea commented Jul 5, 2017

Thank you for contributing!

Oh, the lib/utils/html-elements.json seems wrong. The <slot> elements are valid HTML elements. Could you replace content, shadow, and element (those were dropped from standard) by slot in the lib/utils/html-elements.json?

I think we should add few additional internal vue elements like <router-view> <transition> <transition-group> but they should be not allowed?

Those are embedded custom components. I believe that embedded custom components also need key attributes in iterations.

image

@armano2
Copy link
Contributor Author

armano2 commented Jul 6, 2017

I found out that there is few more missing html5 valid tags:
slot, blockquote, iframe, noframes, picture, tfoot

see https://developer.mozilla.org/en-US/docs/Web/HTML/Element

@armano2
Copy link
Contributor Author

armano2 commented Jul 7, 2017

base on https://github.com/vuejs/vue/blob/dev/src/platforms/web/util/element.js content, shadow, and element can be still in use

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 602d80f into vuejs:master Jul 12, 2017
@armano2 armano2 deleted the patch-2.no-invalid-v-for-slot branch July 12, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants