Skip to content

Fix logic behind kabab case and snake case for propID #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2018
Merged

Fix logic behind kabab case and snake case for propID #641

merged 1 commit into from
Nov 10, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 10, 2018 •
edited
Loading

fix issue #550

assert.equal throws more detailer errors than assert.ok

AssertionError: expected 'XXXXX' to equal 'YYYYY'

instead of

AssertionError: expected false to be truthy

michalsnik
michalsnik approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@michalsnik michalsnik merged commit 023121c into vuejs:master Nov 10, 2018
@armano2 armano2 deleted the casing branch November 10, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @michalsnik