Skip to content

Adding default array example of correct rule #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Adding default array example of correct rule #573

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57cb8c6
Adding default array example of correct rule
guillaumebriday Sep 14, 2018
311bfb1
Updating examples for factory functions
guillaumebriday Sep 19, 2018
9a83eed
Update require-valid-default-prop.md
michalsnik Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/rules/require-valid-default-prop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ props: {
// multiple possible types
propB: [String, Number],
// a number with default value
propC: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is described in the comment of propE as follows,
// object/array defaults should be returned from a factory function
If you add an example near propE, I think that it is easy to understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you're right, I'll make the change !

Also, I think we coud update the propE to use the arrow function ? What do you think about it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumebriday Thank you for your suggestion.
I have looked at other documents.

Many seemed to prefer the shorthand method.
(for example here)
Could you write it in shorthand default () {}?

type: Array,
default: () => []
},
propD: {
type: Number,
default: 100
Expand Down