Fix: html-indent for solo comment (fixes #330)
#333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
force-pushed
the
html-indent/fix-for-solo-comment
branch
from
537bd4c to
7fd45c4
Compare
michalsnik
approved these changes
Jan 7, 2018
mysticatea
force-pushed
the
html-indent/fix-for-solo-comment
branch
from
7fd45c4 to
c17799f
Compare
|
I rebased this PR. |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330.
This PR includes #309 to avoid confliction.
This PR changes the indentation of comments. If it detects solo comment (the next token is closing token and primary expected indentation and secondary expected indentation are same), then makes +1 indentation for the comment. See 7fd45c4 for details.
This change needs
semver-minorbecause it's a bug fix which can increase warnings.