-
-
Notifications
You must be signed in to change notification settings - Fork 680
Upgrade eslint-plugin-html #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I made a couple small updates, most notably updating the version of eslint-plugin-html from beta
to ^2.0.0-beta.0
. I find that preferable, as it's easier to increment the beta number if we need to and if we forget to change this, it doesn't mean we automatically enroll in all future betas.
@yyx990803 I think it might be good to release this with a 2.0 beta tag itself until we're using a stable version of eslint-plugin-html again.
👍 |
processors: { | ||
'.vue': require('eslint-plugin-html').processors['.vue'] | ||
}, | ||
settings: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want curlies here.
Thanks for this plugin!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah definitely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated!
Create core functionality of R package
Fixes #2