Skip to content

Upgrade eslint-plugin-html #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2017
Merged

Upgrade eslint-plugin-html #3

merged 4 commits into from
Jan 17, 2017

Conversation

znck
Copy link
Member

@znck znck commented Jan 17, 2017

Fixes #2

Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I made a couple small updates, most notably updating the version of eslint-plugin-html from beta to ^2.0.0-beta.0. I find that preferable, as it's easier to increment the beta number if we need to and if we forget to change this, it doesn't mean we automatically enroll in all future betas.

@yyx990803 I think it might be good to release this with a 2.0 beta tag itself until we're using a stable version of eslint-plugin-html again.

@chrisvfritz chrisvfritz merged commit 9975b79 into vuejs:master Jan 17, 2017
@znck
Copy link
Member Author

znck commented Jan 17, 2017

👍

@znck znck mentioned this pull request Jan 17, 2017
processors: {
'.vue': require('eslint-plugin-html').processors['.vue']
},
settings: [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want curlies here.

Thanks for this plugin!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah definitely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated!

doug-wade pushed a commit to doug-wade/eslint-plugin-vue that referenced this pull request Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants