[Update] Improve the range of mustache-interpolation-spacing
#276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
changed the title
mustache-interpolation-spacing
michalsnik
approved these changes
Dec 2, 2017
| const openBrace = template.getFirstToken(node) | ||
| const closeBrace = template.getLastToken(node) | ||
|
|
||
| if (!openBrace || !closeBrace || openBrace.type !== 'VExpressionStart' || closeBrace.type !== 'VExpressionEnd') { |
There was a problem hiding this comment.
Can you please wrap those into multiple lines? It'd be easier to read :)
michalsnik
changed the title
mustache-interpolation-spacingmustache-interpolation-spacing
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the range of
vue/mustache-interpolation-spacingerrors.It's currently:
I feel that this is confused a bit because the editor indicates that the errors exist on the identifier
foo. (As a side note, this demo's editor is same as VSCode's, Microsoft/monaco-editor.) So I changed the range of the errors by:The new range of the errors is on
{{and}}.