[Fix] Crash with babel-eslint #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, it requires |
|
Thanks for fixing this! Maybe we can update https://github.com/vuejs/eslint-plugin-vue-libs ? |
# Conflicts: # lib/rules/no-shared-component-data.js
|
I upgraded |
|
I'm not sure why CircleCI job is failing. This project does not depend on @michalsnik Could you rebuild the job without cache? I don't have the permission.
|
|
I fixed the test matter. |
michalsnik
approved these changes
Dec 17, 2017
|
Thanks @mysticatea :) And sorry for not responding earlier.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213.
It intended to show the message "Use the latest vue-eslint-parser", but it crashes.
This PR fixes the crash and adds tests to check that rules don't crash with
babel-eslint.