Update example config to use essential rules #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the `essential` rules make the most sense as a default implied recommendation, as they're the most universally useful, without anything too opinionated. I also updated the comments slightly and commented out the base config and example rule, so that users blindly copying and pasting don't add anything unnecessary. Without it commented out, some users may also assume that `eslint:recommended` is required for the plugin to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the
essentialrules make the most sense as a default implied recommendation, as they're the most universally useful, without anything opinionated.I also updated the comments slightly and commented out the base config and example rule, so that users blindly copying and pasting don't add anything unnecessary. Without it commented out, some users may also assume that
eslint:recommendedis required for the plugin to work.