Skip to content

Allow deprecated rules in configs #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Conversation

FloEdelmann
Copy link
Member

Needed for #2222 (comment). Note that this currently does not change any configs at all.

Also updates emojis in docs to distinguish rules with type "problem" and deprecated rules:

Rule type Previous emoji New emoji
Rules with type "problem" :warning: ⚠️ :warning: ⚠️ (no change)
Deprecated rules :warning: ⚠️ :no_entry_sign: 🚫
Removed rules :no_entry_sign: 🚫 :no_entry:

(does not change current configs at all)
Rules with type "problem": `:warning:` ⚠️ → `:warning:` ⚠️ (no change)
Deprecated rules: `:warning:` ⚠️ → `:no_entry_sign:` 🚫
Removed rules: `:no_entry_sign:` 🚫 → `:no_entry:` ⛔
@FloEdelmann FloEdelmann added documentation meta Code style improvements, build process improvements, refactorings labels Jul 11, 2023
@FloEdelmann FloEdelmann requested a review from ota-meshi July 11, 2023 09:28
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit 9bbef7e into master Jul 22, 2023
@ota-meshi ota-meshi deleted the deprecated-rules-in-configs branch July 22, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation meta Code style improvements, build process improvements, refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants