Create vue/multiline-ternary extension rule
#1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dev1437 Could you please fix the lint issues? Also, there are some tests failing in ESLint v6, @ota-meshi maybe you can help how to skip those tests there? |
|
Not sure why the test fail in eslint v6 but run fine locally, but lint is okay now |
|
It seems that the multiline-ternary rule did not previously support autofix. I think it is necessary to check the version of eslint and ignore the |
ota-meshi
requested changes
Sep 30, 2022
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
FloEdelmann
changed the title
multiline ternary rulevue/multiline-ternary extension rule
ota-meshi
requested changes
Sep 30, 2022
FloEdelmann
reviewed
Oct 5, 2022
Co-authored-by: Flo Edelmann <[email protected]>
…ugin-vue into rule/multiline-ternary
FloEdelmann
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap multiline ternary rule for vue.
Not sure about the indenting, maybe it is not an issue and would be handled by other rules. Looks strange.