Report type-only imports in no-undef-components
#1967
Conversation
|
Two issues in CI:
|
| parser: require.resolve('vue-eslint-parser'), | ||
| errors: [ | ||
| { | ||
| message: "The '<Foo>' component has been used, but not defined.", |
There was a problem hiding this comment.
I think it would be better to make the message clearer. For example:
'<Foo>' component has been used, but 'Foo' only refers to a type.
What do you think?
lib/rules/no-undef-components.js
Outdated
| @@ -130,7 +130,16 @@ module.exports = { | |||
| (scope) => scope.type === 'module' | |||
| ) | |||
| for (const variable of (moduleScope && moduleScope.variables) || []) { | |||
| scriptVariableNames.add(variable.name) | |||
| const definition = variable.defs[0] | |||
| if ( | |||
There was a problem hiding this comment.
I think we can more easily check if it's a value by doing:
if (!variable.isValueVariable || variable.isValueVariable())There was a problem hiding this comment.
This comment of mine was wrong 😓
|
We need to branch using semver regarding test cases failing in tseslint v4. We have already done that in some test cases. |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "ES2020", | |||
There was a problem hiding this comment.
This time I made vuepress support optional chaining operator by lowering the target version.
If it is not proper, please tell me and I will find another way to make it.
There was a problem hiding this comment.
Thanks for looking into what is causing the vuepress build not to work. I didn't know that setting affects vuepress.
There was a problem hiding this comment.
Sorry, I just lost my mind at that moment 😢. This doesn't affect js files, errors just disappear accidentally.
|
Thanks a lot for your comment, they are extremely helpful. |
FloEdelmann
changed the title
no-undef-components
fix #1963