-
-
Notifications
You must be signed in to change notification settings - Fork 681
Add vue/no-ref-object-destructure
rule
#1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick look because I don't have time for a full review of this big PR.
Co-authored-by: Flo Edelmann <[email protected]>
Thank you for the quick review! I have changed the part you commented on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks fine now. As noted earlier, I have not looked deeper into the other parts though.
This seems to have caused a regression on the import {ref} from 'vue';
const something = false;
let columns;
if (something) {
columns = ref([1]);
} else {
columns = ref([2]);
} This used to be fine, with the new version this causes
|
This PR adds
vue/no-ref-object-destructure
rule that reports the destructuring of ref objects causing the value to lose reactivity.close #1949