Skip to content

fix: report delete operation for mutation props #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: report delete operation for mutation props #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,6 +1798,16 @@ module.exports = {
pathNodes
}
}
case 'UnaryExpression': {
if (target.operator === 'delete') {
return {
kind: 'update',
node: target,
pathNodes
}
}
break
}
case 'CallExpression': {
if (pathNodes.length > 0 && target.callee === node) {
const mem = pathNodes[pathNodes.length - 1]
Expand Down
38 changes: 34 additions & 4 deletions tests/lib/rules/no-mutating-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,11 +370,12 @@ ruleTester.run('no-mutating-props', rule, {
<div v-if="this.prop6++ && this.someProp < 10"></div>
<div v-text="this.prop7.shift()"></div>
<div v-text="this.prop8.slice(0).shift()"></div>
<div v-if="delete prop9.a"></div>
</div>
</template>
<script>
export default {
props: ['prop1', 'prop2', 'prop3', 'prop4', 'prop5', 'prop6', 'prop7', 'prop8']
props: ['prop1', 'prop2', 'prop3', 'prop4', 'prop5', 'prop6', 'prop7', 'prop8', 'prop9']
}
</script>
`,
Expand Down Expand Up @@ -402,6 +403,10 @@ ruleTester.run('no-mutating-props', rule, {
{
message: 'Unexpected mutation of "prop7" prop.',
line: 10
},
{
message: 'Unexpected mutation of "prop9" prop.',
line: 12
}
]
},
Expand Down Expand Up @@ -507,6 +512,7 @@ ruleTester.run('no-mutating-props', rule, {
++this.items
this.todo.type = 'completed'
this.items.push('something')
delete this.todo.type
}
}
}
Expand All @@ -524,6 +530,10 @@ ruleTester.run('no-mutating-props', rule, {
{
message: 'Unexpected mutation of "items" prop.',
line: 18
},
{
message: 'Unexpected mutation of "todo" prop.',
line: 19
}
]
},
Expand Down Expand Up @@ -651,6 +661,7 @@ ruleTester.run('no-mutating-props', rule, {
props.a ++
props.b = 1
props.c.push(1)
delete props.d
}
}
</script>
Expand All @@ -667,6 +678,10 @@ ruleTester.run('no-mutating-props', rule, {
{
message: 'Unexpected mutation of "c" prop.',
line: 7
},
{
message: 'Unexpected mutation of "d" prop.',
line: 8
}
]
},
Expand All @@ -681,6 +696,7 @@ ruleTester.run('no-mutating-props', rule, {
c.push(1)

c.x.push(1)
delete c.y
e.foo++
f.foo++
}
Expand All @@ -705,12 +721,16 @@ ruleTester.run('no-mutating-props', rule, {
line: 9
},
{
message: 'Unexpected mutation of "d" prop.',
message: 'Unexpected mutation of "c" prop.',
line: 10
},
{
message: 'Unexpected mutation of "d" prop.',
line: 11
},
{
message: 'Unexpected mutation of "d" prop.',
line: 12
}
]
},
Expand All @@ -722,6 +742,7 @@ ruleTester.run('no-mutating-props', rule, {
export default {
setup({a: foo, b: [...bar], c: baz = 1}) {
foo.x ++
delete foo.y
bar.x = 1
baz.push(1)
}
Expand All @@ -734,12 +755,16 @@ ruleTester.run('no-mutating-props', rule, {
line: 5
},
{
message: 'Unexpected mutation of "b" prop.',
message: 'Unexpected mutation of "a" prop.',
line: 6
},
{
message: 'Unexpected mutation of "c" prop.',
message: 'Unexpected mutation of "b" prop.',
line: 7
},
{
message: 'Unexpected mutation of "c" prop.',
line: 8
}
]
},
Expand All @@ -752,6 +777,7 @@ ruleTester.run('no-mutating-props', rule, {
props.a ++
props.b = 1
props.c.push(1)
delete props.d
}
}
</script>
Expand All @@ -768,6 +794,10 @@ ruleTester.run('no-mutating-props', rule, {
{
message: 'Unexpected mutation of "c" prop.',
line: 7
},
{
message: 'Unexpected mutation of "d" prop.',
line: 8
}
]
},
Expand Down