Add vue/padding-line-between-component-options rule
#1818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
FloEdelmann
requested changes
Mar 16, 2022
FloEdelmann
approved these changes
Mar 16, 2022
FloEdelmann
changed the title
empty-line-between-optionsvue/padding-line-between-component-options rule
|
I wrote a comment. |
FloEdelmann
requested changes
Mar 18, 2022
FloEdelmann
requested changes
Mar 18, 2022
There was a problem hiding this comment.
In the current state, this PR looks fine (apart from one typo).
However, as discussed in the corresponding issue (#1817), the rule has currently many overlaps with new-line-between-multi-line-property. So the suggestions from the issue need to be incorporated. This can either be done in this PR or a new clean one.
|
@barthy-koeln I'll close this for now. If you or anyone else finds the time to implement the new suggestions in #1817, feel free to submit a new pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for suggestion at #1817.