Skip to content

Add multi-word-component-names rule #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

csordasmarton
Copy link
Contributor

Closes #245

@csordasmarton
Copy link
Contributor Author

Netlify gives me the following error: Error: Cannot find module 'eslint'. Can someone help me to fix this problem and also to review my PR?

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!!!
I think the implementation of the rule is mostly good. However, I have some change requests.

@csordasmarton csordasmarton force-pushed the multi_world_component_names branch from 158c459 to 824d35a Compare October 18, 2021 15:41
@csordasmarton
Copy link
Contributor Author

@ota-meshi Thanks for your comments 😊 I think I have fixed all of your comments.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: multi-word-component-names
2 participants