Skip to content

Improve support for spread operator #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2017
Merged

Improve support for spread operator #146

merged 3 commits into from
Aug 14, 2017

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Aug 10, 2017 •
edited
Loading

Fix issues with trying to access undefined properties

  • Cannot read property 'type' of null when return has no argument

Improvements:

  • iterateProperties - utils
  • checkOrder - order-in-components
  • getComputedProperties - utils
  • iterateFunctionExpression - utils
  • add more tests

This changes provide spread operator support support for all rules.

@armano2 armano2 changed the title Fix exceptions in iterateFunctionExpression and iterateProperties: Improve support for spread operator Aug 11, 2017
mysticatea
mysticatea approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit df84d9b into vuejs:master Aug 14, 2017
@armano2 armano2 deleted the iterateFunctionExpression branch August 14, 2017 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @mysticatea