Fix issue return in computed properties & render to match only corret nodes #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
force-pushed
the
patch-29-render-computed-error
branch
from
b760b10 to
5cf8338
Compare
michalsnik
suggested changes
Aug 4, 2017
lib/rules/require-render-return.js
Outdated
| @@ -28,7 +28,8 @@ function create (context) { | |||
| forbiddenNodes.forEach(el => { | |||
| if ( | |||
| el.loc.start.line >= node.value.loc.start.line && | |||
| el.loc.end.line <= node.value.loc.end.line | |||
| el.loc.end.line <= node.value.loc.end.line && | |||
| node.value === el | |||
There was a problem hiding this comment.
I think simple:
el.loc.start.line === node.value.loc.start.line
would be enough, or even just:
node.value === el
wdyt? (I was sceptic but looks like this kind of comparison works just fine for ASTs)
Plus I think that this line should be moved to extecuteOnFunctionsWithoutReturn:
- if (!isValidReturn()) {
+ if (!isValidReturn() && !node.expression) {There was a problem hiding this comment.
@michalsnik thank you for tips 🍡
| @@ -28,7 +28,8 @@ function create (context) { | |||
| if ( | |||
| cp.value && | |||
| el.loc.start.line >= cp.value.loc.start.line && | |||
| el.loc.end.line <= cp.value.loc.end.line | |||
| el.loc.end.line <= cp.value.loc.end.line && | |||
| cp.value.parent === el | |||
michalsnik
reviewed
Aug 4, 2017
lib/rules/require-render-return.js
Outdated
| ) | ||
| if (!node) return | ||
|
|
||
| forbiddenNodes.forEach(el => { | ||
| if ( | ||
| el.loc.start.line >= node.value.loc.start.line && | ||
| el.loc.end.line <= node.value.loc.end.line | ||
| el.loc.end.line <= node.value.loc.end.line && | ||
| el.loc.start.line === node.value.loc.start.line |
There was a problem hiding this comment.
I meant we can remove all other conditions and leave only this one. Or even just leave:
node.value === el
:D up to you, we only want to check if the forbidden node is the same as the render's property value
There was a problem hiding this comment.
yup, i need a bit more ☕️
armano2
force-pushed
the
patch-29-render-computed-error
branch
from
251d12f to
88c0d75
Compare
michalsnik
approved these changes
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #130