Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: add no-use-computed-property-like-method rules #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: add no-use-computed-property-like-method rules #1234
Changes from 7 commits
b14d0f3
6b0b860
4d8ae20
7aaf02d
f5c426c
e97c749
c61acae
587d808
f460c6f
969120a
7ce7a03
cc7cde4
62b82be
c614b6d
13eff80
01c4f84
9c54158
00dc589
78c203d
96fecb1
3edce05
330d188
11b7ef1
8b825e5
2e316f8
d8a8af9
986648b
b06421b
7459eea
d885a36
ccbee98
c2bc020
c082183
3b77c4e
ce93fa6
60e7c48
7cb18fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found an error in some cases. Could you add the following test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll do that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ota-meshi
I changed some codes to support the above cases.
3b77c4e
ce93fa6
However, I will not support this case:
Because this rule only checkes whether computed properties are expected as property or not.
In this case, computed is not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want support. I've found that using a rule in that source code reports a crash or an incorrect error, so I just want to add test cases to tests if it's okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I just make sense of what you said :)
I added test case
7cb18fe