feat: add fixable, no more error when unused variable with prefix _ #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement proposal vuejs#1058 feat vuejs#1058
ota-meshi
requested changes
Mar 8, 2020
There was a problem hiding this comment.
Thank you for this PR.
I like to allow users to ignore variables with specific names.
But, I think it should be an option like varsIgnorePattern, just like ESLint's no-unused-vars.
https://eslint.org/docs/rules/no-unused-vars
The vue/no-unused-vars rule cannot distinguish between varsIgnorePattern and argsIgnorePattern, so I think it's better to add ignorePattern option.
Also, if we change the variable name by auto fix, it may conflict with other variables. So, could you change it so that it does not autofix it.
|
okay, i will do that. |
ota-meshi
requested changes
Mar 9, 2020
ota-meshi
approved these changes
Mar 9, 2020
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement proposal #1058
feat #1058