-
-
Notifications
You must be signed in to change notification settings - Fork 681
Fix iterateProperties to support arrow functions #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
Could you add test cases to the following rules.
- no-dupe-keys
- no-reserved-keys
- no-template-shadow
@ota-meshi , added same cases but with 2 types of arrow functions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Thank you, for approving. So what's next? We need some other review? We are going to release project soon where we need this changes, we could use fork there, but this changes seems quite useful for everyone, that's why we made PR. |
Hi @frenchrabbit. |
Ok, thank you. Looking forward to see it in release. |
current iterateProperties doesn't support arrow function properties. However it supports functions and iterate their returned objects.
So we can't treat properties from arrow functions same way:
default way works:
But following examples won't work:
or like this:
Pull request adds support for
ArrowFunctionExpression
initerateProperties
.