Skip to content

refactor: use Array.includes() to check for existence #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2019
Merged

refactor: use Array.includes() to check for existence #1013

merged 2 commits into from
Dec 26, 2019

Conversation

jamesgeorge007
Copy link
Contributor

Leverage the Array.includes() method to check for existence over indexOf which is kinda obsolete.

armano2
armano2 previously requested changes Dec 26, 2019
View reviewed changes
@ota-meshi ota-meshi merged commit c19c37b into vuejs:master Dec 26, 2019
@jamesgeorge007 jamesgeorge007 deleted the refactor branch December 26, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armano2 armano2 armano2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @armano2 @ota-meshi