Skip to content

Rule proposal: v-if-else-key #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michalsnik opened this issue Nov 26, 2017 · 1 comment · Fixed by #2280
Closed

Rule proposal: v-if-else-key #255

michalsnik opened this issue Nov 26, 2017 · 1 comment · Fixed by #2280
Labels
new rule proposition Present in Style Guide

Comments

@michalsnik
Copy link
Member

Style guide:
https://vuejs.org/v2/style-guide/#v-if-v-if-else-v-else-without-key-use-with-caution

Description:
This rule would enforce to add key property on elements with v-if and v-else directives if they're both of the same type.
@michalsnik michalsnik mentioned this issue Nov 26, 2017
Closed
@mysticatea mysticatea self-assigned this Dec 31, 2017
@chrisvfritz
Copy link
Contributor

This is very much related to our discussion here. The same requirements regarding key with v-for exist for v-if, so maybe these should even be in the same rule, perhaps called require-key-on-stateful-enumerated-elements?

@mysticatea mysticatea removed their assignment Nov 23, 2018
doug-wade added a commit to doug-wade/eslint-plugin-vue that referenced this issue Apr 13, 2022
@doug-wade
fix vuejs#255: Add new rule require-v-if-else-key
6a8f18a
@FloEdelmann FloEdelmann linked a pull request Apr 13, 2022 that will close this issue
fix #255: Add new rule require-v-if-else-key #1845
Closed
doug-wade added a commit to doug-wade/eslint-plugin-vue that referenced this issue Apr 16, 2022
@doug-wade
vuejs#255 respond to pr feedback
07e58c0
@felipemelendez felipemelendez mentioned this issue Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new rule proposition Present in Style Guide
Projects
None yet
Milestone
No milestone
3 participants
@mysticatea @chrisvfritz @michalsnik