Skip to content

Rename vue/component-tags-order to vue/block-order #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FloEdelmann opened this issue Jun 15, 2023 · 2 comments · Fixed by #2222
Closed

Rename vue/component-tags-order to vue/block-order #2214

FloEdelmann opened this issue Jun 15, 2023 · 2 comments · Fixed by #2222

Comments

@FloEdelmann
Copy link
Member

We use the word "block" in rule names to refer to the top-level tags in Vue SFCs:

However, the vue/component-tags-order rule does not fit that schema. I suggest to rename the rule to vue/block-order:

  1. In the next minor version, add vue/block-order as a copy of vue/component-tags-order and deprecate the latter.
  2. In the next major version, remove vue/component-tags-order completely.

Are there other rules for which it would make sense to rename them for consistency and/or clarity?

@wenfangdu
Copy link
Contributor

Are there other rules for which it would make sense to rename them for consistency and/or clarity?

vue/padding-line-between-blocks => vue/newline-between-blocks
vue/padding-line-between-tags => vue/newline-between-tags
vue/padding-lines-in-component-definition => vue/newlines-in-component-definition

"newline" is more intuitive and easier to search on the rules page.

@FloEdelmann
Copy link
Member Author

But it matches the core padding-line-between-statements rule name, so I'd rather not change them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants