Skip to content

How to make parser work on plain js files. #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armano2 opened this issue Jul 26, 2017 · 1 comment · Fixed by #123
Closed

How to make parser work on plain js files. #109

armano2 opened this issue Jul 26, 2017 · 1 comment · Fixed by #123
Assignees
@armano2
Labels
accepted proposition enhancement work in progress
Milestone
v4.0.0 - Official...

Comments

@armano2
Copy link
Contributor

armano2 commented Jul 26, 2017

I looked into my projects and i found out one missing functionality here, sometimes we can create abstract components in js files with no template, with or without render function and in that case eslint is not going to work with this file because he don't know that this is a component.

Solution:
I propose to add a way to instruct parser to treat files with comment /* @vue/component */ as vue components.
@michalsnik
Copy link
Member

I like this idea 👍 We're not able to catch all scenarios and this would definitely help.

armano2 added a commit to armano2/eslint-plugin-vue that referenced this issue Aug 2, 2017
@armano2
Allow to use @vue/component to set type of file to vue
d0a4c40 
fixes vuejs#109
@armano2 armano2 mentioned this issue Aug 2, 2017
Merged
@michalsnik michalsnik added this to the Official release milestone Aug 3, 2017
armano2 added a commit to armano2/eslint-plugin-vue that referenced this issue Aug 4, 2017
@armano2
Allow to use @vue/component to set type of file to vue
78a111a 
fixes vuejs#109
armano2 added a commit to armano2/eslint-plugin-vue that referenced this issue Aug 4, 2017
@armano2
Allow to use @vue/component to set type of file to vue
eacc0d0 
fixes vuejs#109
armano2 added a commit to armano2/eslint-plugin-vue that referenced this issue Aug 6, 2017
@armano2
Allow to use @vue/component to set enable parsing vue objects
b7b4991 
fixes vuejs#109
michalsnik pushed a commit that referenced this issue Aug 8, 2017
@armano2 @michalsnik
Allow to use @vue/component to set enable parsing vue objects (#123)
4d0c1d3 
* Allow to use @vue/component to set enable parsing vue objects
fixes #109

* Add support for eslint 4.x
LineComment and BlockComment was removed in 4.0.0

* Remove unessesery function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armano2 armano2

Labels
accepted proposition enhancement work in progress
Projects
None yet
Milestone
v4.0.0 - Official release
Development

Successfully merging a pull request may close this issue.

Allow to use @vue/component to set enable parsing vue objects armano2/eslint-plugin-vue
2 participants
@armano2 @michalsnik