Web Components: Add Event Handling Caveat #1890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@LinusBorg I see you were assigned to review. Any thoughts? |
Co-authored-by: skirtle <[email protected]>
|
LGTM |
|
Hold it for now - I believe this should be considered a bug and is fixable. |
@yyx990803 For camelCase it mighr be, i think i even have an open PR for that? Not sure 😅 But in Vue core we map |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
…mes on custom elements close vuejs/docs#1708 close vuejs/docs#1890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The custom elements section currently includes an incorrect score from Custom Elements Everywhere. Even if Custom Elements Everywhere decided to accept custom directives as satisfactory (which they have not), I don't think the score is all that relevant. Bottom line: custom elements work, and there are some caveats.
The caveat around listening for events with capital letters currently is not documented, and neither is the recommended solution.
Proposed Solution
Additional Information
Related issue: vuejs/core#5401
Related closed PR: #1553
Related RFC discussion: vuejs/rfcs#451
Closes #1708