Skip to content

Update Vue School offer banner #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Update Vue School offer banner #1680

merged 5 commits into from
Apr 25, 2022

Conversation

nicodevs
Copy link
Contributor

@nicodevs nicodevs commented Apr 22, 2022

This PR updates the text and style of the Vue School top banner introduced in #1653

The banner is closable and opens Vue School's promo page in a new tab. The banner will not reappear if a user has closed it (stored in localStorage).

Please merge on the first minute of Monday 25th.

Click here to see screenshots of the banner

@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 051aabc
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6262dc791c86440008f9199f
😎 Deploy Preview https://deploy-preview-1680--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nicodevs nicodevs marked this pull request as ready for review April 22, 2022 16:23
@yyx990803 yyx990803 merged commit a7af382 into vuejs:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants