Skip to content

Added transition mode default #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Added transition mode default #1632

merged 1 commit into from
Mar 30, 2022

Conversation

vHeemstra
Copy link
Contributor

@vHeemstra vHeemstra commented Mar 23, 2022

Description of Problem

According to the TypeScript interface (here) the default mode is default.

This was missing from the docs.

Proposed Solution

So I added it to this API docs page.

Additional Information

However, this might also be useful to mention in the guide where it introduces the mode parameter/attribute (VueJS.org / GitHub source). So developers know what to use for the default behaviour (if you have to set it explicitly).

It might seem obvious when you know the default value is default... but otherwise you might try an empty string, or 'sync' / false / null / etc.

According to the TypeScript interface [here](https://github.com/vuejs/core/blob/main/packages/runtime-core/src/components/BaseTransition.ts#L24) the default mode is `default`. This was missing from the docs.
@netlify
Copy link

netlify bot commented Mar 23, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit b32e28e
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/623ab28f3cd3960008687541
😎 Deploy Preview https://deploy-preview-1632--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition.

Personally I think it's sufficient to include the value in just the API and not the guide. I don't think the need to set it explicitly to 'default' comes up often enough to justify covering it in the guide.

@skirtles-code skirtles-code merged commit 11ae1e2 into vuejs:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants