feat: NativeScript support #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
reviewed
Aug 3, 2018
shells/electron/index.js
Outdated
| @@ -1,9 +1,20 @@ | |||
| require('./build/hook.js') | |||
|
|
|||
| const target = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : {} | |||
There was a problem hiding this comment.
Can we make it a little bit more readable?
shells/electron/src/backend.js
Outdated
| @@ -3,26 +3,29 @@ import { initBackend } from 'src/backend' | |||
| import Bridge from 'src/bridge' | |||
| import { installToast } from 'src/backend/toast' | |||
|
|
|||
| const host = window.__VUE_DEVTOOLS_HOST__ || 'http://localhost' | |||
| const port = window.__VUE_DEVTOOLS_PORT__ !== undefined ? window.__VUE_DEVTOOLS_PORT__ : 8098 | |||
| const target = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : {} | |||
src/backend/highlighter.js
Outdated
| let overlayContent | ||
|
|
||
| function init () { | ||
| if (init.isInitialized) return |
There was a problem hiding this comment.
Maybe we can merge these two conditions?
src/backend/highlighter.js
Outdated
| range.selectNode(node) | ||
| return range.getBoundingClientRect() | ||
| if (!isBrowser) return | ||
| if (getTextRect.range) getTextRect.range = document.createRange() |
There was a problem hiding this comment.
Perhaps we can create a variable outside of this function instead of assigning range to the function itself? It's a bit confusing atm
michalsnik
approved these changes
Aug 3, 2018
|
Is this something that has the potential to make it in to 5.0? |
|
Yes, as noted in the Release notes, the first beta doesn't contain all the things. 😸 |
17 tasks
|
How could I test this? Would love to give it a whirl :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes RouterView component tree not loading fix as well.