Skip to content

Show key values in vue developers console #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ build
tests_output
selenium-debug.log
TODOs.md
.idea
6 changes: 3 additions & 3 deletions shells/dev/target/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ new Vue({
h(Counter),
h(Target, { props: { msg: 'hi', ins: new MyClass() }}),
h(Other),
h(Events),
h(NativeTypes),
h(Router)
h(Events, { key: 'foo' }),
h(NativeTypes, { key: new Date() }),
h(Router, { key: [] })
])
},
data: {
Expand Down
15 changes: 15 additions & 0 deletions src/backend/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ function capture (instance, _, list) {
const ret = {
id: instance.__VUE_DEVTOOLS_UID__,
name: getInstanceName(instance),
renderKey: getRenderKey(instance.$vnode ? instance.$vnode['key'] : null),
inactive: !!instance._inactive,
isFragment: !!instance._isFragment,
children: instance.$children
Expand Down Expand Up @@ -694,6 +695,20 @@ function getUniqueId (instance) {
return `${rootVueId}:${instance._uid}`
}

function getRenderKey (value) {
if (value == null) return
const type = typeof value
if (type === 'number') {
return value
} else if (type === 'string') {
return `'${value}'`
} else if (Array.isArray(value)) {
return 'Array'
} else {
return 'Object'
}
}

/**
* Display a toast message.
* @param {any} message HTML content
Expand Down
61 changes: 55 additions & 6 deletions src/devtools/views/components/ComponentInstance.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
@mouseenter="enter"
@mouseleave="leave"
:class="{ selected: selected }"
:style="{ paddingLeft: depth * 15 + 'px' }">
:style="{ paddingLeft: depth * 15 + 'px' }"
>
<!-- Component tag -->
<span class="content">
<!-- arrow wrapper for better hit box -->
<span class="arrow-wrapper"
Expand All @@ -21,7 +23,16 @@
<span class="arrow right" :class="{ rotated: expanded }">
</span>
</span>
<span class="angle-bracket">&lt;</span><span class="item-name">{{ displayName }}</span><span class="angle-bracket">&gt;</span>

<span class="angle-bracket">&lt;</span>

<span class="item-name">{{ displayName }}</span>

<span v-if="componentHasKey" class="attr">
<span class="attr-title"> key</span>=<span class="attr-value">{{instance.renderKey}}</span>
</span>

<span class="angle-bracket">&gt;</span>
</span>
<span
v-if="instance.consoleId"
Expand All @@ -48,14 +59,17 @@
>
inactive
</span>

<span class="spacer"></span>

<VueIcon
class="icon-button"
icon="visibility"
v-tooltip="'Scroll into view'"
@click="scrollToInstance"
/>
</div>

<div v-if="expanded">
<component-instance
v-for="child in sortedChildren"
Expand All @@ -69,44 +83,57 @@

<script>
import { mapState } from 'vuex'
import { classify, scrollIntoView } from '../../../util'
import { classify, scrollIntoView, UNDEFINED } from '../../../util'
export default {
name: 'ComponentInstance',
props: {
instance: Object,
depth: Number
},
created () {
// expand root by default
if (this.depth === 0) {
this.expand()
}
},
computed: {
...mapState('components', [
'classifyComponents'
]),
scrollToExpanded () {
return this.$store.state.components.scrollToExpanded
},
expanded () {
return !!this.$store.state.components.expansionMap[this.instance.id]
},
selected () {
return this.instance.id === this.$store.state.components.inspectedInstance.id
},
sortedChildren () {
return this.instance.children.slice().sort((a, b) => {
return a.top === b.top
? a.id - b.id
: a.top - b.top
})
},
displayName () {
return this.classifyComponents ? classify(this.instance.name) : this.instance.name
},
componentHasKey () {
return !!this.instance.renderKey && this.instance.renderKey !== UNDEFINED
}
},
watch: {
scrollToExpanded: {
handler (value, oldValue) {
Expand All @@ -117,35 +144,44 @@ export default {
immediate: true
}
},
methods: {
toggle (event) {
this.toggleWithValue(!this.expanded, event.altKey)
},
expand () {
this.toggleWithValue(true)
},
collapse () {
this.toggleWithValue(false)
},
toggleWithValue (val, recursive = false) {
this.$store.dispatch('components/toggleInstance', {
instance: this.instance,
expanded: val,
recursive
})
},
select () {
bridge.send('select-instance', this.instance.id)
},
enter () {
bridge.send('enter-instance', this.instance.id)
},
leave () {
bridge.send('leave-instance', this.instance.id)
},
scrollToInstance () {
bridge.send('scroll-to-instance', this.instance.id)
},
scrollIntoView (center = true) {
this.$nextTick(() => {
scrollIntoView(this.$globalRefs.leftScroll, this.$refs.self, center)
Expand Down Expand Up @@ -233,16 +269,29 @@ export default {
color $component-color
margin 0 1px
.attr
opacity .5
font-size 12px
.attr-title
color purple
.spacer
flex 100% 1 1
width 0
flex auto 1 1
.icon-button
font-size 16px
width 16px
height 16px
.self:not(:hover) &
visibility hidden
.self.selected & >>> svg
fill $white
.self.selected
.attr
opacity 1
.attr-title
color lighten($purple, 70%)
</style>