Skip to content

Fix overlapping text and icon #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Conversation

AlbertLucianto
Copy link
Contributor

Workaround on issue #389

Some changes on styling. One is by replacing fixed height with min-height for adjustment during word break.

Then, some labels might be out of the container. This problem can be solved by adding pseudo element, creating new line which contains the labels.

It seems no test update is required for this fix.

Really appreciate for the review.

screen shot 2018-01-24 at 11 39 29 pm
screen shot 2018-01-24 at 11 39 55 pm
screen shot 2018-01-24 at 11 40 10 pm

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Akryum Akryum added this to the v4.1.1 milestone Jan 24, 2018
@Akryum Akryum merged commit 9adc316 into vuejs:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants