Minor adjustments #495
Merged
Minor adjustments #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would invert the two icons. 😛 |
|
I like this. How does it look on a narrower width though? I assume the text hides? |
|
Personally, I would stick the search to the right and stick Inspect DOM and Refresh to the Component name |
|
@posva Every other header (component tree, vuex/events history and vuex inspector) have the search field on the left and the buttons on the right. |
|
|
|
|
|
Thanks for the improvements @Akryum , I had to take a little trip. |
anteriovieira
commented
Jan 14, 2018
| <i class="material-icons">code</i> | ||
| <span>Inspect DOM</span> | ||
| </a> | ||
| <a class="button" @click="openInEditor" v-tooltip="openEditorTooltip"> | ||
| <a | ||
| v-if="target.file" |
There was a problem hiding this comment.
@Akryum in this case could remove condition if in theopenInEditor function.
yyx990803
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the latest improvements have been really amazing, congratulations to all who contributed.
I would just like to suggest these minor changes:
This keeps a pattern in the headers
In my opinion it makes more evident the existence of the resource and standardizes the feature as buttons in the header.
The launch icon makes it clear that the user is moved to an inspection screen.
What are your thoughts on this?