Skip to content

Improve scannability of the right side panel #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

b44rd
Copy link

@b44rd b44rd commented Aug 15, 2017

Proposing a simple solution for enhancing the readability of the different parts within the right side panel. Attached are previews of how this will look inside both standard and dark theme.

skjermbilde 2017-08-15 kl 20 43 07

skjermbilde 2017-08-15 kl 20 42 50

@b44rd b44rd force-pushed the restyle-data-fields branch 2 times, most recently from 86efc04 to 5ba4ba8 Compare August 15, 2017 18:56
@b44rd b44rd force-pushed the restyle-data-fields branch from 5ba4ba8 to c4cdcfa Compare August 15, 2017 18:57
@posva
Copy link
Member

posva commented Aug 15, 2017

Personally, I really like how it looks. I think we should change the green for the panel title background, especially in dark mode, it's way too catchy for the eye. Maybe a grey color in both themes will be enough.
What do you think @yyx990803

@b44rd
Copy link
Author

b44rd commented Aug 15, 2017

Glad to hear! I agree with you that the green color is a bit to flashy. Here´s two screenshots of a local copy where the green color is replaced with grey tones. It might indeed work out for the better. 👍

skjermbilde 2017-08-15 kl 22 01 19

skjermbilde 2017-08-15 kl 22 00 21

@b44rd
Copy link
Author

b44rd commented Sep 1, 2017

@yyx990803 Thoughts on this one?

@yyx990803
Copy link
Member

I actually like the green headers in bright mode. Gray headers in bright mode makes it feel like those boxes are "disabled" in some way. Gray headers does look much better in dark mode.

My only nitpick would be: in bright mode, raising the brightness of the gray background a bit more and add a subtle drop shadow for each box.

@b44rd b44rd force-pushed the restyle-data-fields branch 4 times, most recently from 0852a28 to cfa77e8 Compare September 4, 2017 07:09
@b44rd
Copy link
Author

b44rd commented Sep 4, 2017

The pull request is now updated. I´ve now made the header background green inside light mode, and grey inside dark mode, which seem to work really well. The light mode has also got a subtile drop shadow now. Had some trouble making the background of the right column fit to the box inside light mode, so defined some background inside ScrollPane.vue and SplitPane.vue as well in order to avoid adding css hacks here.

@b44rd b44rd force-pushed the restyle-data-fields branch from cfa77e8 to def3d8d Compare September 4, 2017 10:47
@b44rd
Copy link
Author

b44rd commented Oct 9, 2017

@posva @yyx990803 Will this one be merged anytime soon? Thinking about creating a pull request that adds a options control at the right side of each header as well. Useful features inside this can be collapse all/expand all and order keys (default/a-z/z-a).

@yyx990803
Copy link
Member

@b44rd sorry for letting this sit - was busy with the release of 2.5. However, taking another look after a while makes me reconsider the change. I like the idea of making the headers of each section more prominent, but the background + cards feels a bit inconsistent with the style of the rest of the devtools.

@b44rd
Copy link
Author

b44rd commented Oct 25, 2017

@yyx990803 Yeah, you might be right about that. The dark version works a bit better than the light version, I think. Was mainly chosing cards since it made the contents group better. It also allow the headers to later be extended with filtering options, such as ordering options, expand all/collapse all.

If you have any suggestions to improve the design though, let me know, and I´ll see what I can do. 👍

@Akryum
Copy link
Member

Akryum commented Dec 23, 2017

See #477

@b44rd
Copy link
Author

b44rd commented Jan 3, 2018

Closing PR, as #477 is a much better solution. 👍

@b44rd b44rd closed this Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants