Skip to content

Vuex panel display state recursively #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
louim opened this issue Oct 17, 2018 · 0 comments · Fixed by #829
Closed

Vuex panel display state recursively #802

louim opened this issue Oct 17, 2018 · 0 comments · Fixed by #829

Comments

@louim
Copy link

louim commented Oct 17, 2018

Version

5.0.0-beta.3

Browser and OS info

Chrome 70.0.3538.67 / Mac OS X 10.13

Steps to reproduce

Apologies if I can't offer clearer reproduction steps.
I was using Vue devtools 4.1.5 beta, and switched to 5.0.0.beta 3 to get Vuex mutations on init (#723).
Since switching, my state is displayed recursively in the Vuex panel.

What is expected?

State correspond to actual store state. (this is what is looks like in 4.1.5 beta)
capture d ecran 2018-10-17 a 16 01 20

What is actually happening?

State is shown recursively. At the end of a mutation, the state is shown as still "recording"? (this is what is looks like in 5.0.0.beta 3)
capture d ecran 2018-10-17 a 16 02 44
Once I click the button, the state look like this:
capture d ecran 2018-10-17 a 16 03 09

Details

This is what my state looks like when I hit the export button in 4.1.5 beta:

{
  "loading": false,
  "annotable": "gid://elite/Project/14",
  "notes": {
    "notes": [
      {
        "id": 1,
        "body": "some text.\nSome more text.",
        "createdAt": "2018-10-11T16:04:19.117-04:00",
        "updatedAt": "2018-10-12T16:04:51.489-04:00",
        "user": {
          "id": 336,
          "name": "N S",
          "email": "redacted"
        },
        "url": "http://localhost:3000/notes/1?locale=fr"
      },
      {
        "id": 2,
        "body": "Hello!\n\nBye!",
        "createdAt": "2018-10-11T16:04:19.117-04:00",
        "updatedAt": "2018-10-12T16:04:44.359-04:00",
        "user": {
          "id": 336,
          "name": "N S",
          "email": "redacted"
        },
        "url": "http://localhost:3000/notes/2?locale=fr"
      },
      {
        "id": 3,
        "body": "a brand new note!",
        "createdAt": "2018-10-12T15:20:13.090-04:00",
        "updatedAt": "2018-10-12T15:20:13.090-04:00",
        "user": {
          "id": 336,
          "name": "N S",
          "email": "redacted"
        },
        "url": "http://localhost:3000/notes/3?locale=fr"
      },
      {
        "id": 5,
        "body": "Nouvelle note from JP edited",
        "createdAt": "2018-10-12T16:39:55.575-04:00",
        "updatedAt": "2018-10-12T16:42:57.025-04:00",
        "user": {
          "id": 325,
          "name": "A B",
          "email": "redacted"
        },
        "url": "http://localhost:3000/notes/5?locale=fr"
      },
      {
        "id": 7,
        "body": "test test\ntest",
        "createdAt": "2018-10-12T18:37:57.620-04:00",
        "updatedAt": "2018-10-16T17:46:29.152-04:00",
        "user": {
          "id": 325,
          "name": "A B",
          "email": "redacted"
        },
        "url": "http://localhost:3000/notes/7?locale=fr"
      },
      {
        "id": 8,
        "body": "Brand new note",
        "createdAt": "2018-10-16T17:47:32.018-04:00",
        "updatedAt": "2018-10-16T17:47:32.018-04:00",
        "user": {
          "id": 325,
          "name": "A B",
          "email": "redacted"
        },
        "url": "http://localhost:3000/notes/8?locale=fr"
      }
    ],
    "model": {}
  }
}

This is what the state looks like when I export state in 5.0.0.beta 3

[
  {
    "loading": 1,
    "annotable": 0,
    "notes": 2
  },
  false,
  {
    "notes": 0,
    "model": 3
  },
  {}
]

Let me know if I can provide more details.

Akryum added a commit that referenced this issue Jan 25, 2019
…802 (#829)

* test(e2e): test mutation payload

* Fix payload on replaying mutation

* test(e2e): fix expect


Co-authored-by: Guillaume Chau <[email protected]>
simsim0709 pushed a commit to simsim0709/vue-devtools that referenced this issue May 7, 2019
…, closes vuejs#802 (vuejs#829)

* test(e2e): test mutation payload

* Fix payload on replaying mutation

* test(e2e): fix expect


Co-authored-by: Guillaume Chau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants