Guide: using-with-vue-router.md #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaty
added
Relecture nécessaire
Traduction en cours
and removed
Traduction en cours
labels
Kocal
requested changes
Oct 15, 2017
| @@ -1,10 +1,10 @@ | |||
| # Using with Vue Router | |||
| # Utiliser avec Vue Router | |||
|
|
||
| To avoid this, we can create a localVue, and install Vue Router on that. | ||
| Pour éviter cela, on va utiliser localVue et installer Vue Router avec. |
There was a problem hiding this comment.
on peut utiliser une localVue, et installer Vue Router dessus
|
|
||
| ### Using stubs | ||
| ### Utiliser stubs |
|
|
||
| To avoid this, never install Vue Router when you're running tests. | ||
| Pour éviter cela, n'installez jamais Vue Router quand vous lancez vos tests. * TODO : est-ce que c'est vraiment le message à faire passer ? * |
There was a problem hiding this comment.
Pour éviter cela, n'installez jamais Vue Router directement sur Vue mais sur localVue, lorsque vous lancez vos tests.
J'ai pas la science infuse, mais je trouve que cette phrase a déjà beaucoup + de sens que la phrase originale ^^
MachinisteWeb
requested changes
Oct 21, 2017
|
|
||
| To avoid this, we can create a localVue, and install Vue Router on that. | ||
| Pour éviter cela, on peut utiliser une localVue, et installer Vue Router dessus. |
|
|
||
| When we run tests, we need to make these vue-router components available to the component we're mounting. There are two methods to do this. | ||
| On doit donc rendre ces composants vue-router disponibles au composant que nous testons. Il y a deux méthodes pour cela. |
| @@ -44,13 +44,13 @@ shallow(Component, { | |||
| }) | |||
| ``` | |||
|
|
|||
| ## Mocking `$route` and `$router` | |||
| ## Simuler `$route` and `$router` | |||
rspt
approved these changes
Oct 21, 2017
Kocal
approved these changes
Oct 22, 2017
MachinisteWeb
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traduction du fichier using-with-vue-router.md.
Je n'ai fait qu'une seule relecture, ça risque d'être un peu brut et pas forcement trop agréable à lire. A voir :)
J'ai un doute à la toute dernière phrase.