Skip to content

Statistic Component #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2019
Merged

Statistic Component #802

merged 5 commits into from
May 28, 2019

Conversation

Chris-Kin
Copy link

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. add the Statistic component to ant-design-vue.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. It's just adding a new component, will not affect existing things.

Changelog description (Optional if not new feature)

  1. add the Statistic component to ant-design-vue.
  2. 添加Statistic组件.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented May 25, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 1b16a43

https://app.netlify.com/sites/ant-desing-vue/deploys/5cec8a2095426900095345d0

@tangjinzhou tangjinzhou requested a review from wangxueliang May 25, 2019 10:27
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #802 into feat-1.4.0 will increase coverage by 0.02%.
The diff coverage is 89.47%.

Impacted file tree graph

@@              Coverage Diff               @@
##           feat-1.4.0     #802      +/-   ##
==============================================
+ Coverage       87.91%   87.93%   +0.02%     
==============================================
  Files             150      155       +5     
  Lines            5237     5313      +76     
  Branches         1534     1553      +19     
==============================================
+ Hits             4604     4672      +68     
- Misses            587      595       +8     
  Partials           46       46
Impacted Files Coverage Δ
components/index.js 93.75% <ø> (ø) ⬆️
components/statistic/index.js 100% <100%> (ø)
components/statistic/utils.js 100% <100%> (ø)
components/statistic/Countdown.jsx 82.14% <82.14%> (ø)
components/statistic/Number.jsx 89.47% <89.47%> (ø)
components/statistic/Statistic.jsx 92.3% <92.3%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f1047...200f920. Read the comment docs.

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #802 into feat-1.4.0 will increase coverage by 0.08%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##           feat-1.4.0   #802      +/-   ##
============================================
+ Coverage       87.91%    88%   +0.08%     
============================================
  Files             150    155       +5     
  Lines            5237   5317      +80     
  Branches         1534   1554      +20     
============================================
+ Hits             4604   4679      +75     
- Misses            587    592       +5     
  Partials           46     46
Impacted Files Coverage Δ
components/index.js 93.75% <ø> (ø) ⬆️
components/statistic/index.js 100% <100%> (ø)
components/statistic/utils.js 100% <100%> (ø)
components/statistic/Countdown.jsx 82.14% <82.14%> (ø)
components/statistic/Number.jsx 89.47% <89.47%> (ø)
components/statistic/Statistic.jsx 94.11% <94.11%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f1047...1b16a43. Read the comment docs.

| Events Name | Description | Arguments |
| --- | --- | --- |
| onFinish | Trigger when time's up | () => void | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是finish

#### Statistic.Countdown事件
| 事件名称 | 说明 | 回调参数 |
| --- | --- | --- |
| onFinish | 倒计时完成时触发 | () => void |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@wangxueliang wangxueliang merged commit 15c645f into vueComponent:feat-1.4.0 May 28, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants