-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: support vue3.4.x to ant-design-vue 3.x #7252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tangjinzhou 是否考虑发布兼容版本?目前3.x版本存量用户还有很多 |
components/affix/index.tsx
Outdated
@@ -261,7 +260,8 @@ const Affix = defineComponent({ | |||
]); | |||
return ( | |||
<ResizeObserver onResize={updatePosition}> | |||
<div {...restProps} style={placeholderStyle} ref={placeholderNode}> | |||
<div {...restProps} ref={placeholderNode} data-measure-status={status}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是不是多了一个 div,再核对下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
@selicens is this pr stalled? We need this desperately in our project. We have to update Vue to 3.4, but can't update Ant to 4.x because there are too many breaking changes. 🙏 🙏 🙏 |
啥时候能发一版啊,大佬们 |
@tangjinzhou @selicens 唐老师,3.x版本能不能把这个pr合并进去,发个bugfix版本,解决下vue升级到3.4以后出现的问题,毕竟还有不少人在用3.x |
啥时候能发一版啊,大佬们 |
我再跟进一些 |
大佬,有消息吗 |
My company is also being impacted by this. We have multiple widget libraries using ant-design-vue 3.x and new projects with vue 3.4 are broken. |
ant-design-vue 4.x 和vue3.4.x Modal.confirm无法关闭 |
这个没进展了吗 |
自己本地patch个补丁,自己玩自己的 😄 |
这个在 ci 机器上打包用的还是本地 patch 这个包吗 |
shide |
还是没进展吗, |
催催唐老师,我看3.x版本修复了好几个问题,都没有发布,估计是JSX全局命名在3.4没有了,导致一直失败 |
pls support and merge it. thanks |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
哥,这个要怎么做,能提供个 gist 参考下吗 |
@selicens 有进展吗? |
没有,可能v3维护周期已经到了,建以采用patch的形式处理 |
这个没进展了么?真的是踩大坑了.... |
v4 一堆 mr 也没合并 |
antdv3.2.20啥时候能发一版啊 |
应该不得发了,建议自行patch |
可惜了 自己patch会不会很容易被npm i覆盖 (看来antdv3.2.20用不了vue新版本了) |
让唐老师亮出收款码吧,一人一点捐助下!我看下不知道理解的对不对,好像就是vue 的ts的命名空间改了导致一直失败 |
不会,你都自己patch怎么会被覆盖呢? |
哈哈哈 估计没空搭理这点小钱 |
算是开玩笑吧,其实3的存量应该非常多,本来就是开源的,也不能绑架唐老师。只能只要了。其实我想给这个贡献,但是又怕搞得不对,很纠结zzzz |
自己patch没弄过 有教程嘛 目前antdv3.2.20用不了vue3.4 3.5了 |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
December 2024 and still the bug exist. Please support this. thanks |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
synch 4.0
#7257