fix(StyleContext): fix style cache duplicate creation #7029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibayanyu20
changed the title
tangjinzhou
requested changes
Oct 17, 2023
| const instance = getCurrentInstance(); | ||
| let cache: CacheEntity; | ||
| if (instance && instance.appContext) { | ||
| const globalCache = instance.appContext?.config?.globalProperties?.__ANTDV_CSSINJS_CACHE__; |
There was a problem hiding this comment.
在第113的部分最外面有一个，不这样处理的话会不会影响到 #6912 这个issue
|
@tangjinzhou 刚刚本地跑了一下，如果是他这种情况的话，还是会导致其他的实例无法正常的挂上样式 |
tangjinzhou
approved these changes
Oct 17, 2023
| const instance = getCurrentInstance(); | ||
| let cache: CacheEntity; | ||
| if (instance && instance.appContext) { | ||
| const globalCache = instance.appContext?.config?.globalProperties?.__ANTDV_CSSINJS_CACHE__; |
|
挂实例上就没有问了吗 |
是的每一个vue的实例单独分配一个cache就好使 |
|
那就酱紫 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #7023