Skip to content

fix: scroll measure not work fine on ff of win #579 #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2019
Merged

fix: scroll measure not work fine on ff of win #579 #627

merged 1 commit into from
Mar 25, 2019

Conversation

sendya
Copy link
Member

@sendya sendya commented Mar 24, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

scroll measure not work fine on ff of win #579

API Realization (Optional if not new feature)

  1. from react-component/table@12335c2#diff-2b4ca49d4bb0a774c4d4c1672d7aa781

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
    fix scroll measure not work fine on ff of win
  2. Chinese description (optional)
    修正滚动条计算在 windows 下 firefox 无法正确计算的问题

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

windwos firefix bug:

// 有 overflow: 'scroll' 时,ff 下 offsetHeight  与 clientHeight 同高
size = scrollDiv.offsetHeight - scrollDiv.clientHeight; 

20190325010906

@netlify
Copy link

netlify bot commented Mar 24, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 4bc78c5

https://app.netlify.com/sites/ant-desing-vue/deploys/5c97bee7cd2c4b0008c2fe02

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         145      145           
  Lines        4810     4810           
  Branches     1418     1418           
=======================================
  Hits         4196     4196           
  Misses        571      571           
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4410f77...4bc78c5. Read the comment docs.

@tangjinzhou tangjinzhou merged commit 8fbeed1 into vueComponent:master Mar 25, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants