Skip to content

fix[notification]: onClose event runs repeatedly #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2022
Merged

fix[notification]: onClose event runs repeatedly #6150

merged 1 commit into from
Dec 11, 2022

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Dec 10, 2022

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Chinese description

使用 notification 的时候,它绑定了 mouseLeavemouseEnter 事件。在我点击关闭按钮后,unMounted 事件运行后,又会运行 mouseLeave 事件,导致清除了定时器后又新建了一个定时器。所以会调用两次 notificationonClose 事件两次。

@kovsu
Copy link
Member Author

kovsu commented Dec 10, 2022

4NT79YHKS~2{`{4S4)W__7

@kovsu
Copy link
Member Author

kovsu commented Dec 10, 2022

GQXYO3$ME8`Q8)FOEP8(5

@kovsu kovsu changed the title feat: onClose event runs repeatedly fix[notification]: onClose event runs repeatedly Dec 10, 2022
@tangjinzhou tangjinzhou merged commit 7ea18a8 into vueComponent:main Dec 11, 2022
@kovsu kovsu deleted the feature branch December 11, 2022 07:39
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The notification component clicks the close icon and calls the onClose function repeatedly
2 participants