Skip to content

Update edit-cell.md #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Update edit-cell.md #605

merged 1 commit into from
Mar 19, 2019

Conversation

HelloMoli
Copy link
Contributor

@HelloMoli HelloMoli commented Mar 18, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Mar 18, 2019

Deploy preview for ant-desing-vue processing.

Building with commit aecc6d1

https://app.netlify.com/sites/ant-desing-vue/deploys/5c8f89aebd22ad0007e9107f

@HelloMoli
Copy link
Contributor Author

修改了 edit-cell 的官方demo 第一次贡献

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #605 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   87.23%   87.21%   -0.03%     
==========================================
  Files         145      145              
  Lines        4810     4810              
  Branches     1418     1418              
==========================================
- Hits         4196     4195       -1     
  Misses        571      571              
- Partials       43       44       +1
Impacted Files Coverage Δ
components/upload/UploadList.jsx 89.41% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82081f1...aecc6d1. Read the comment docs.

@tangjinzhou tangjinzhou requested a review from sendya March 18, 2019 14:03
@sendya
Copy link
Member

sendya commented Mar 18, 2019

经测试确实官方 demo 的代码无法直接取到结果

使用 $event 或者 arguments 可以获取到 this.$emit('change', this.value); 所传递的值

修改前:

修改后:

@HelloMoli
Copy link
Contributor Author

那组织有空更新下官网吧 我把issue关了

@tangjinzhou tangjinzhou merged commit 9f9ab21 into vueComponent:master Mar 19, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants