Skip to content

fix raf bug #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix raf bug #5502

wants to merge 1 commit into from

Conversation

Jackliu007888
Copy link

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@Jackliu007888
Copy link
Author

#5501

@tangjinzhou
Copy link
Member

这里不会泄露啊 能定位到具体哪个组件吗

@Jackliu007888
Copy link
Author

@tangjinzhou 我下午再看看。昨晚按这样改完 alinode没报 onTimeout的问题,早上还发现
wrapperRaf.cancel 的写法有问题, 应该是 cleanup(id) 而不是 cleanup(realId)

@Jackliu007888
Copy link
Author

@tangjinzhou 我这边测试
let raf = (callback: FrameRequestCallback) => +setTimeout(callback, 16);

去掉+ 则正常,可以不清定时器
不去掉 + 则会内存泄漏,清定时器 则正常

具体问题我没深究,可能是因为 node的setTimeout 返回的是一个 Timeout 对象?

@tangjinzhou
Copy link
Member

所以你是 SSR 泄露 ?

@Jackliu007888
Copy link
Author

@tangjinzhou 对,用的nuxt3

@tangjinzhou
Copy link
Member

那去掉+ 好了

tangjinzhou added a commit that referenced this pull request Apr 23, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants