Skip to content

fix Slider tipFormatter types #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2021
Merged

fix Slider tipFormatter types #4954

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6683f7c
Update index.tsx
Ludidi Nov 30, 2021
c040e49
Update index.tsx
Ludidi Dec 1, 2021
80ee760
Merge branch 'vueComponent:next' into Ludidi-patch-1
Ludidi Dec 1, 2021
dc6de44
Update index.tsx
tangjinzhou Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/slider/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const sliderProps = () => ({
disabled: { type: Boolean, default: undefined },
vertical: { type: Boolean, default: undefined },
tipFormatter: {
type: Function as PropType<(value?: number) => any>,
type: Function as PropType<(value?: number) => any | null>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

type: [Function, Object] as PropType<((value?: number) => any) | null>,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

((value?: number) => any) 要加括号

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我直接 commit 了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的😅

default: defaultTipFormatter,
},
tooltipVisible: { type: Boolean, default: undefined },
Expand Down