fix(modal): type notation should be parenthesized in ModalFuncProps #4667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShenQingchuan
changed the title
|
再确认下 ？ 这里已经改了呢 并已经发版 |
title?: (() => VNodeTypes) | VNodeTypes;注意已经加了括号了 |
|
好的，那我将关闭这个 PR |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tangjinzhou Sorry for #4664，我找到病根了
原本的类型定义是这样的：
这意味着 TS 认为 title 是一个函数，返回的是 VNodeTypes | VNodeTypes
也就是 VNodeTypes 本身
该错误可详见 Playground Reproduce：
https://www.typescriptlang.org/play?#code/C4TwDgpgBAglC8UDOwBOBLAdgcygHykwFcBbAIwlQG4AoUSKAIQSgAoBKBAPln1lpoAbCMChkAXExYByFBhzSB9aAGEWcAh278aQA
所以应该改为：